feat: Noir transfer function for milestone 1.5#244
Merged
Conversation
sirasistant
changed the title
ludamad
reviewed
Apr 13, 2023
LeilaWang
reviewed
Apr 13, 2023
LeilaWang
approved these changes
Apr 13, 2023
This reverts commit ea1d944.
Maddiaa0
pushed a commit
that referenced
this pull request
Apr 14, 2023
* fix: wip noir 1.5 * rand_idx hack to prevent repreated rand oracle removal * fix: various fixes for noir 1.5 * fix: readded change note * wip trying to fix transfer * refactor(noir): refactored noir-aztec3 * chore: udpate bytecode of constructor and mint * fix: work around bug by passing root as input * refactor: remove debug stuffs * feat: wip support for dummy notes * fix(noir): worked around a weird transfer bug * chore: switch to brillig oracles * refactor(sim): recurse by creating nested classes * refactor(noir): is_dummy and dummy notes creation * chore(noir): update bytecode * log: added a log in execution * Revert "chore: switch to brillig oracles" This reverts commit ea1d944. --------- Co-authored-by: Joss <joss@aztecprotocol.com>
Maddiaa0
added a commit
that referenced
this pull request
Apr 14, 2023
* Enabled multiple tests against same rollup contract * fix: skip lower check on empty leaves * fix: update nt insertion algo * fix: redo nt algo * temp * Enabled multiple tests against same rollup contract * fix: skip lower check on empty leaves * fix: update nt insertion algo * fix: redo nt algo * clean * clean * chore(circuits): bump to fix pr * chore(circuits(: bump using new dummy composer * chore(circuits): bump to master * chore: build in yarn test * refactor: minor sequencer cleanup (#251) * bump circuits * add acirHash to PrivateCallData, bump circuits, fix primitives.wasm build/cmake, make sure circuits is built with USE_TURBO * remove inherit from circuits.js package.json because it was removing timeout * revert circuits.js/package.json update circuits submodule now that it uses USE_TURBO in dockerfiles * fix: re-add timeout * clean: update test syntax * Bump typescript and jest versions (#267) * Remove ts-ignores when creating memdown instances * Bump ts version * Bump jest and friends versions * Update snapshots * fix: bump circuits, USE_TURBO, acirHash, bump circuits.js timeout (#263) * chore: build in yarn test * bump to latest circuits master now that PR with contract root / address fix is merged * add acirHash to PrivateCallData, bump circuits, fix primitives.wasm build/cmake, make sure circuits is built with USE_TURBO * shouldn't need timeout... --------- Co-authored-by: ludamad <domuradical@gmail.com> Co-authored-by: cheethas <urmasurda@gmail.com> * feat: Noir transfer function for milestone 1.5 (#244) * fix: wip noir 1.5 * rand_idx hack to prevent repreated rand oracle removal * fix: various fixes for noir 1.5 * fix: readded change note * wip trying to fix transfer * refactor(noir): refactored noir-aztec3 * chore: udpate bytecode of constructor and mint * fix: work around bug by passing root as input * refactor: remove debug stuffs * feat: wip support for dummy notes * fix(noir): worked around a weird transfer bug * chore: switch to brillig oracles * refactor(sim): recurse by creating nested classes * refactor(noir): is_dummy and dummy notes creation * chore(noir): update bytecode * log: added a log in execution * Revert "chore: switch to brillig oracles" This reverts commit ea1d944. --------- Co-authored-by: Joss <joss@aztecprotocol.com> * fix: review comments * revert: circuitsjs timeout * fix: uncomment nullifier tree test * Revert "Enabled multiple tests against same rollup contract" This reverts commit 8ff5909. * fix e2e block building test merge * add private key to config * improve e2e running times (#252) * add config from env vars in projects + update e2e config * remove comment * Fix automatic import * remove comments * remove hardcoded addresses + reduce .isMined poll freq * more chagnes to isMined freq * fix zero EthAddress * chore(circuits): bump * chore(circuits): bump * chore(circuits): back to master * fix: up maxtxs per block --------- Co-authored-by: PhilWindle <philip.windle@gmail.com> Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: ludamad <domuradical@gmail.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com> Co-authored-by: dbanks12 <david@aztecprotocol.com> Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com> Co-authored-by: Joss <joss@aztecprotocol.com> Co-authored-by: spypsy <spypsy@outlook.com> Co-authored-by: spypsy <spypsy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the transfer function for milestone 1.5, added dummy note generation and refactored a bit the noir-aztec3 library
Checklist: